DirectFB - Home of the pragmatist Roadmap


[directfb-dev] Re: [PATCH] IFusionSoundMusicProvider (timidity)
Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[directfb-dev] Re: [PATCH] IFusionSoundMusicProvider (timidity)



Quoting Ville Syrjälä:
> This patch adds IFusionSoundMusicProvider interface. It's pretty much a
> direct copy of IDirectFBVideoProvider. Maybe the name shouldn't have
> "music" in it since it's not limited to music...
> 
> I had to move some of the structs to the header files so that I could
> access them from the provider.
> 
> The included timidity is ripped from some version of SDL.
> 
> The only app I have using this right now is my jjffe port. I just couldn't
> play it without music so I had to do this patch :)

Great, one part of the FusionSound TODO list ;)

I have two concerns though. The core structures like CoreSoundBuffer should
stay hidden in the .c file for safetiness and compatibility. We should also
avoid exposing private interface data.
What about adding IFusionSoundStream::GetDescription() which gets all values
or even the original description passed to IFusionSoundStream_Construct()?

> PS.
> I was also thinking that there should be another type of provider that
> renders into a IFusionSoundBuffer. Like image vs. video providers.

Hmm, maybe IFusionSoundMusicProvider::PlayAll() or DecodeTo().

There shouldn't be an extra interface, because one may want to decode small
samples from mp3 files to a buffer or play large mp3 files via stream.

-- 
Best regards,
  Denis Oliver Kropp

.------------------------------------------.
| DirectFB - Hardware accelerated graphics |
| http://www.directfb.org/                 |
"------------------------------------------"

                            Convergence GmbH


-- 
Info:  To unsubscribe send a mail to ecartis@directfb.org with 
"unsubscribe directfb-dev" as subject.



Home | Main Index | Thread Index


directfb.org / Development / Old Archives